Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mail: add test case on empty HTML to NewSingleEmail #268

Merged
merged 1 commit into from
Sep 28, 2018
Merged

mail: add test case on empty HTML to NewSingleEmail #268

merged 1 commit into from
Sep 28, 2018

Conversation

arxdsilva
Copy link
Contributor

Related to #266

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Sep 18, 2018
@SendGridDX
Copy link

SendGridDX commented Sep 18, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@thinkingserious thinkingserious added type: community enhancement feature request not on Twilio's roadmap difficulty: medium fix is medium in difficulty labels Sep 28, 2018
@thinkingserious thinkingserious merged commit ac34e22 into sendgrid:master Sep 28, 2018
@thinkingserious
Copy link
Contributor

Hello @arxdsilva,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@arxdsilva
Copy link
Contributor Author

hi @thinkingserious, thanks for the swag, that was very unexpected :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
difficulty: medium fix is medium in difficulty status: code review request requesting a community code review or review from Twilio type: community enhancement feature request not on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arxdsilva @SendGridDX @thinkingserious